Add analyzer to detect empty test methods (MSTEST0056) #6523
+596
−9
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements a new analyzer that warns developers about empty test methods, which are useless pieces of code that should either be removed or have meaningful test logic added.
What's New
The analyzer introduces diagnostic MSTEST0056 with the following behavior:
Warns about empty test methods:
Ignores methods with meaningful content:
Implementation Details
[TestMethod]
attribute or derived attributes (like[DataTestMethod]
)The analyzer uses operation analysis to distinguish between truly empty methods and those with meaningful statements. It correctly handles:
Localization
Full localization support has been added across all 13 supported languages with appropriate resource entries.
Testing
Comprehensive test coverage includes positive and negative test cases for all supported scenarios, ensuring the analyzer correctly identifies empty test methods while avoiding false positives.
Fixes #6518.
Warning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
m8dvsblobprodcus37.vsblob.vsassets.io
/home/REDACTED/work/testfx/testfx/.dotnet/dotnet msbuild /m /nologo /clp:Summary /v:minimal /nr:true /warnaserror /p:TreatWarningsAsErrors=true /p:ContinuousIntegrationBuild=false /home/REDACTED/work/testfx/testfx/artifacts/toolset/restore.proj /t:__WriteToolsetLocation /clp:ErrorsOnly;NoSummary /p:__ToolsetLocationOutputFile=/home/REDACTED/work/testfx/testfx/artifacts/toolset/11.0.0-beta.25453.1.txt
(dns block)dotnet build src/Analyzers/MSTest.Analyzers/MSTest.Analyzers.csproj
(dns block)If you need me to access, download, or install something from one of these locations, you can either:
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.