Update submodule for new cherry-picks #1996
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakebailey
commented
Oct 31, 2025
| +++ new.variancePropagation.errors.txt | ||
| @@= skipped -0, +0 lines =@@ | ||
| -<no content> | ||
| +variancePropagation.ts(13,7): error TS2322: Type 'DerivedTable<{ base: Base; new: New; }>' is not assignable to type 'DerivedTable<{ base: Base; new: New & Base; }>'. |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates a TypeScript submodule to incorporate new cherry-picks that change the ordering of properties in error messages to be alphabetical rather than declaration order.
Key changes:
- Updates TypeScript submodule reference to a newer commit
- Modifies numerous test baseline files to reflect the new alphabetical property ordering in error messages
- Adds new test files for variance propagation functionality
Reviewed Changes
Copilot reviewed 19 out of 19 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
_submodules/TypeScript |
Updates submodule commit hash to incorporate cherry-picks |
Multiple .diff files in testdata/baselines/reference/submodule*/ |
Updates test baselines to reflect alphabetical property ordering in TypeScript error messages |
variancePropagation.* files |
Adds new test files for variance propagation functionality |
RyanCavanaugh
approved these changes
Oct 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before #1916