Implement more handling of client capabilities #1998
Merged
+208
−40
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
jakebailey
commented
Nov 1, 2025
jakebailey
commented
- Handle plaintext-only clients for hover, completion doc.
- Handle clients that don't support LocationLink in find all ref.
- Handle clients that can't do hierarchical symbols.
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for client capabilities negotiation in the LSP server, allowing the server to respond with appropriate content formats based on client preferences. The changes ensure proper handling of hover content, completion documentation, document symbols, and implementation results according to what the client supports (e.g., markdown vs plaintext, hierarchical vs flat symbols, location links vs simple locations).
Key changes:
- Added client capability checks for hover, completion, document symbols, and implementations to detect supported formats
- Modified hover and completion response formatting to respect client-supported content formats (markdown vs plaintext)
- Added hierarchical vs flat symbol information support based on client capabilities
- Added LocationLink support for implementations when client supports it
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| internal/lsp/server.go | Added helper functions to extract client capabilities and updated handlers to pass these capabilities to language service methods |
| internal/ls/hover.go | Modified hover provider to conditionally format content as markdown or plaintext based on client capabilities |
| internal/ls/completions.go | Updated completion item resolution to use client-preferred documentation format |
| internal/ls/string_completions.go | Updated string literal completion details to pass plaintext format |
| internal/ls/symbols.go | Added support for both hierarchical and flat document symbol formats |
| internal/ls/findallreferences.go | Added LocationLink support for implementations when client supports it |
| internal/fourslash/fourslash.go | Added default capabilities for testing with markdown and plaintext formats |
sheetalkamat
approved these changes
Nov 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.