[WIP][http-client-js]Enable e2e cases #6551
Draft
+11,776
−25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MaryGao
commented
Mar 20, 2025
| } | ||
|
|
||
| declare type String_2 = string; | ||
| export { String_2 as String } |
There was a problem hiding this comment.
Need to fix the _N suffix issue.
MaryGao
commented
Mar 20, 2025
|
|
||
| export declare function dateDeserializer(date?: string | null): Date; | ||
|
|
||
| export declare function dateRfc3339Serializer(date?: Date | null): string; |
There was a problem hiding this comment.
Should not export internal interfaces.
|
❌ There is undocummented changes. Run The following packages have changes but are not documented.
Show changes |
MaryGao
commented
Mar 20, 2025
|
|
||
| export declare function encodeUint8Array(value: Uint8Array | undefined | null, encoding: BufferEncoding): string | undefined; | ||
|
|
||
| export declare class ExplicitBodyClient { |
There was a problem hiding this comment.
Should not expose internal clients.
This was referenced Mar 20, 2025
MaryGao
commented
Mar 20, 2025
| declare interface PutOptions_8 extends OperationOptions { | ||
| } | ||
|
|
||
| declare interface PutOptions_9 extends OperationOptions { |
There was a problem hiding this comment.
Duplicated names with suffix _N issue.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Missing features