Mock process before importing #8626
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
microsoft-github-policy-service
bot
added
the
compiler:core
timotheeguerin
commented
Sep 30, 2025
| compilerHost: NodeHost, | ||
| compilerHost: { | ||
| ...NodeHost, | ||
| getJsImport: (path: string) => { |
There was a problem hiding this comment.
only doing this in the server right now but feels like this probably should just be in the NodeHost because right now the repro will let tsp compile stuck
commit: |
|
❌ There is undocummented changes. Run The following packages have changes but are not documented.
Show changes |
|
You can try these changes here
|
bterlson
approved these changes
Sep 30, 2025
timotheeguerin
commented
Sep 30, 2025
| const result = NodeHost.getJsImport(path); | ||
| return result; | ||
| } finally { | ||
| globalThis.process.stdin = oldProcess.stdin; |
RodgeFu
reviewed
Oct 1, 2025
| let result: any; | ||
| process.exit = (() => { | ||
| // for module that calls process.exit when being imported, create an empty object as it's exports to avoid load it again | ||
| result = {}; |
There was a problem hiding this comment.
it's better for loadJsFile to return a mock result or throw so that the caller can do something for the "bad" lib. otherwise, cache won't work for these "bad" lib and we will keep loading the "bad" lib every time unnecessary.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #8624
To prevent bad packages from corrupting the language server mock the process which is something you shouldn't be using anyway