2025-08-29 Regressions Fixes #1774
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Resolves the 'fastdds' failures observed in microsoft/vcpkg#47130 Note that the POSIX version of these functions already filter for ENOENT and ENOTDIR: if (::stat(full.c_str(), &s) != 0) { if (errno == ENOENT || errno == ENOTDIR) { ec.clear(); }
Fixes the wcslib:x64-android failures.
Hopefully fixes:
error: open_for_read("/mnt/vcpkg-ci/p/salome-configuration_x64-linux/share/salome-configuration/copyright/modules.info"): Permission denied
Examples of what the added test does before the fixes. I don't know how to reasonably add a test for the 'permission denied' repro case on Linux but I hope just adding paranoia around that is OK. |
vicroms
approved these changes
Sep 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1744 introduced a lot of regressions into how vcpkg installs ports, particularly around handling symlinks and files we can't read.
Previously, all calls to the filesystem looking at the packages tree explicitly ignored errors. However, in #1744 recursive directory enumeration and opening the files to write hashes was added with the "crash on error" VCPKG_LINE_INFO forms.
This exposed some latent bugs in how we handle symlinks in recursive enumeration (which is good!).