-
Notifications
You must be signed in to change notification settings - Fork 7k
[vtk] Fix features and cross builds #46843
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b72273e
to
e7a760a
Compare
... closer to initialization.
In contrast to VTK_FEATURE_OPTIONS, say NO instead of DONT_WANT. This forces features to explicitly model true dependencies and helps avoid hidden installation order problems. Start with feature sql <-> dependency sqlite3.
Group MPI implies mpi requirements for other dependencies.
... and use vcpkg_get_vcpkg_installed_python().
4fff42f
to
39b9c78
Compare
8 tasks
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
BillyONeal
approved these changes
Sep 3, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the fixes! Fingers crossed this also helps with the funny behavior we're seeing on modern macOS :/
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enable crosscompiling.
Fix feature python.
Devendor gl2ps.
Tighten wiring between features/dependencies and capabilities.
Resolve some feature configuration issues.
Fix wiring of MPI with regard to hdf5 installations with MPI.
Some cleanup.