Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move explorer to Azure viewContainer #169

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Loghorn
Copy link
Contributor

@Loghorn Loghorn commented Oct 2, 2018

See microsoft/vscode-azuretools#167

This will move the IoT Hub Devices explorer to the Azure viewContainer, along with others Azure plugins.

@formulahendry
Copy link
Member

Hi @Loghorn , thanks for your PR. 😃 However, if we move the IoT Hub Devices explorer to the Azure viewContainer, users may have more context switch between the devices and files. So I'd like to keep this PR open for more discussion and user feedback.

@Loghorn
Copy link
Contributor Author

Loghorn commented Oct 12, 2018

Sure, I understand.
I proposed the change for consistency with the other azure extensions, but you are right that this could end in more context switch.

@hammar
Copy link
Member

hammar commented Feb 27, 2022

I didn't notice this PR and just submitted the duplicate #542 that does more or less the exact same thing (though it adds a dependency on another Azure extension, rather than redefines the Azure view container locally). Sorry!

For the discussion on context switching you bring up: I (and, I assume, many other devs) use VS Code for a variety of tasks, some of which are within the Azure ecosystem, and some of which are not. It is definitely jarring to have Azure things pop up outside of the Azure view container; that itself is more of a context switch for me. So a vote from me as a user is to merge this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants