Skip to content

Commit

Permalink
Update release/1.19 (#4075)
Browse files Browse the repository at this point in the history
* update node version, @vsce/vsce, and fix build errors from node updat… (#4055)

* update node version, @vsce/vsce, and fix build errors from node update, add improved signing

* update node in ci builds

* update vscode engine

* fix copy

* don't sign vsix with VsixSha2 anymore

* update changelog

* xml2js cg (#4069)

* xml2js cg

* update tests as well

* try update partial

* switch kit?

* ninja is added to path so it should work, still investigating

* update action version with same tool versions

* changes to test

* test output

* more testing

* test macos-13

* remove logging

* remove logging

* try explicit macos-14

* go back to macos-13

* remove static version of vscode

* need to use 13

* comment

* update node (#4072)

* ensure ready to release (#4074)

* ensure ready to release

* update third party

* update workflows (#4076)
  • Loading branch information
gcampbell-msft authored Sep 17, 2024
1 parent 406216a commit 21fa776
Show file tree
Hide file tree
Showing 18 changed files with 1,354 additions and 576 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/build-vsix.yml
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ jobs:
- name: Setup Node.js environment
uses: actions/[email protected]
with:
node-version: '16'
node-version: '20'
check-latest: true

- name: Get Short SHA
Expand Down
11 changes: 7 additions & 4 deletions .github/workflows/ci-main-linux.yml
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,9 @@ name: CI (Linux)

on:
push:
branches: [ main, rel ]
branches: [ main, 'release/**' ]
pull_request:
branches: [ main, rel ]
branches: [ main, 'release/**' ]

jobs:
build:
Expand All @@ -16,7 +16,7 @@ jobs:
- name: Setup Node environment
uses: actions/setup-node@v3
with:
node-version: 16
node-version: 20

- name: Install Yarn
run: npm install -g yarn
Expand All @@ -31,7 +31,10 @@ jobs:
run: yarn lint

- name: Install CMake/Ninja
uses: lukka/[email protected]
uses: lukka/[email protected]
with:
cmakeVersion: 3.18.3
ninjaVersion: 1.10.1

- name: Build fake compilers for tests
uses: urkle/[email protected]
Expand Down
13 changes: 8 additions & 5 deletions .github/workflows/ci-main-mac.yml
Original file line number Diff line number Diff line change
Expand Up @@ -2,21 +2,21 @@ name: CI (macOS)

on:
push:
branches: [ main, rel ]
branches: [ main, 'release/**' ]
pull_request:
branches: [ main, rel ]
branches: [ main, 'release/**']

jobs:
build:
runs-on: macos-latest
runs-on: macos-13 # TODO: This is a workaround until macos-14 is fixed: https://github.com/actions/runner-images/issues/10624

steps:
- uses: actions/checkout@v3

- name: Setup Node environment
uses: actions/setup-node@v3
with:
node-version: 16
node-version: 20

- name: Install Yarn
run: npm install -g yarn
Expand All @@ -31,7 +31,10 @@ jobs:
run: yarn lint

- name: Install CMake/Ninja
uses: lukka/[email protected]
uses: lukka/[email protected]
with:
cmakeVersion: 3.18.3
ninjaVersion: 1.10.1

- name: Build fake compilers for tests
uses: urkle/[email protected]
Expand Down
11 changes: 7 additions & 4 deletions .github/workflows/ci-main.win.yml
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,9 @@ name: CI (Windows)

on:
push:
branches: [ main, rel ]
branches: [ main, 'release/**' ]
pull_request:
branches: [ main, rel ]
branches: [ main, 'release/**' ]

jobs:
build:
Expand All @@ -17,7 +17,7 @@ jobs:
- name: Setup Node environment
uses: actions/setup-node@v3
with:
node-version: 16
node-version: 20

- name: Install Yarn
run: npm install -g yarn
Expand All @@ -33,7 +33,10 @@ jobs:

# The cmake server mode has been removed since CMake 3.20
- name: Install CMake/Ninja
uses: lukka/[email protected]
uses: lukka/[email protected]
with:
cmakeVersion: 3.18.3
ninjaVersion: 1.10.1

- name: Build fake compilers for tests
uses: urkle/[email protected]
Expand Down
8 changes: 8 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,7 +1,15 @@
# What's New?

## 1.19.52

Improvements:

- Update signing to support VSCode extension signing. [#4055](https://github.com/microsoft/vscode-cmake-tools/pull/4055)

## 1.19.51

Bug Fixes:

- Fix generator and preferredGenerator logic. [#4031](https://github.com/microsoft/vscode-cmake-tools/issues/4031), [#4005](https://github.com/microsoft/vscode-cmake-tools/issues/4005), [#4032](https://github.com/microsoft/vscode-cmake-tools/issues/4032)

## 1.19.50
Expand Down
Loading

0 comments on commit 21fa776

Please sign in to comment.