Ensure signing/packaging works as expected (#4088)

* test out signing js and packaging it without messing up sign

* yarn compile-production

* temp image override

* confirmed, this fixes signing

jobs/release/prerelease.yml

@@ -29,9 +29,6 @@ extends:
         templateContext:
           type: releaseJob
           isProduction: true
-          sdl:
-            codeSignValidation:
-              additionalTargetsGlobPattern: -|**\*.js
           inputs:
           - input: pipelineArtifact
             pipeline: BuildPrereleasePipeline

jobs/release/release.yml

@@ -61,9 +61,6 @@ extends:
         templateContext:
           type: releaseJob
           isProduction: true
-          sdl:
-            codeSignValidation:
-              additionalTargetsGlobPattern: -|**\*.js
           inputs:
           - input: pipelineArtifact
             pipeline: BuildReleasePipeline

jobs/shared/build.yml

@@ -58,7 +58,7 @@ steps:
   displayName: Build files
   inputs:
     script: |
-      npm run vscode:prepublish
+      yarn compile-production
 - task: MSBuild@1
   displayName: Sign files
   inputs:

package.json

@@ -3677,7 +3677,6 @@
     "@test": "out/test/"
   },
   "scripts": {
-    "vscode:prepublish": "yarn run compile-production",
     "compile": "yarn install && webpack --mode development",
     "compile-watch": "yarn install && webpack --mode development --watch --progress",
     "compile-production": "yarn install && yarn run translations-generate && webpack --env BUILD_VSCODE_NLS=true --mode production",