Update changelog for 1.9.2 and document a property better (#2261)

microsoft · Nov 24, 2021 · 56f28b7 · 56f28b7
1 parent e90af9c
commit 56f28b7
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 6 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,9 +1,11 @@
 # What's New?
 
-## 1.10.0
+## 1.9.2
 Bug fixes:
+- Fix infinite recursion into symlinks. [#2257](https://github.com/microsoft/vscode-cmake-tools/issues/2257)
 - Fix `Show Build Command` for folders that do not use CMake Presets. [#2211](https://github.com/microsoft/vscode-cmake-tools/issues/2211)
-- Fix IntelliSense usage of short name from variants file for buildType. [#2120](https://github.com/microsoft/vscode-cmake-tools/issues/2120)
+- Fix presets not shown when a common dependency is inherited more than once. [#2210](https://github.com/microsoft/vscode-cmake-tools/issues/2210)
+- Fix IntelliSense usage of short name from variants file for buildType. [#2120](https://github.com/microsoft/vscode-cmake-tools/issues/2120) [@gost-serb](https://github.com/gost-serb)
 
 ## 1.9.1
 Bug fixes:

diff --git a/src/cmake-tools.ts b/src/cmake-tools.ts
@@ -393,12 +393,12 @@ export class CMakeTools implements vscode.Disposable, api.CMakeToolsAPI {
     private readonly _targetName = new Property<string>(this._initTargetName);
 
     /**
-     * The current variant
+     * The current variant name for displaying to the UI (not the buildType)
      */
-    get activeVariant() {
+    get activeVariantName() {
         return this._activeVariant.value;
     }
-    get onActiveVariantChanged() {
+    get onActiveVariantNameChanged() {
         return this._activeVariant.changeEvent;
     }
     private readonly _activeVariant = new Property<string>('Unconfigured');

diff --git a/src/extension.ts b/src/extension.ts
@@ -804,7 +804,7 @@ class ExtensionManager implements vscode.Disposable {
             this._targetNameSub = cmt.onTargetNameChanged(FireNow, t => {
                 this._statusBar.setBuildTargetName(t);
             });
-            this._buildTypeSub = cmt.onActiveVariantChanged(FireNow, bt => this._statusBar.setVariantLabel(bt));
+            this._buildTypeSub = cmt.onActiveVariantNameChanged(FireNow, bt => this._statusBar.setVariantLabel(bt));
             this._launchTargetSub = cmt.onLaunchTargetNameChanged(FireNow, t => {
                 this._statusBar.setLaunchTargetName(t || '');
             });