find Best Generator (#2600)

CHANGELOG.md

@@ -3,6 +3,9 @@
 ## 1.11.26
 - Revert back to the previous CMake language server extension dependency. [PR #2599](https://github.com/microsoft/vscode-cmake-tools/pull/2599)
 
+Bug Fixes:
+- Ninja is used as a default generator. [#2598](https://github.com/microsoft/vscode-cmake-tools/issues/2598) 
+
 ## 1.11.25
 Improvements:
 - Fix build Error: EMFILE: too many open files. [#2288](https://github.com/microsoft/vscode-cmake-tools/issues/2288) [@FrogTheFrog](https://github.com/FrogTheFrog)

src/drivers/cmakeDriver.ts

@@ -770,6 +770,12 @@ export abstract class CMakeDriver implements vscode.Disposable {
         }
     }
 
+    isCommonGenerator(genName: string): boolean {
+        return genName === 'Ninja' || genName === 'Ninja Multi-Config' ||
+            genName === 'MinGW Makefiles' || genName === 'NMake Makefiles' ||
+            genName === 'Unix Makefiles' || genName === 'MSYS Makefiles';
+    }
+
     /**
      * Picks the best generator to use on the current system
      */
@@ -809,7 +815,8 @@ export abstract class CMakeDriver implements vscode.Disposable {
                 if (gen.name.toLowerCase().startsWith('xcode') && platform === 'darwin') {
                     return gen;
                 }
-                if (this.cmakeGenerators.indexOf(gen.name) >= 0) {
+                // If it is not a common generator that we can find, but it is a known cmake generator (cmakeGenerators), return it.
+                if (this.cmakeGenerators.indexOf(gen.name) >= 0 && !this.isCommonGenerator(gen.name)) {
                     return gen;
                 }
                 continue;