ensure we apply our presets to local cache (#3503)

* ensure we apply our presets to local cache * update changelog * update changelog --------- Co-authored-by: snehara99 <[email protected]>
microsoft · Jan 2, 2024 · e31987c · e31987c
1 parent a8703f2
commit e31987c
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 1 deletion.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -5,7 +5,7 @@ Bug Fixes:
 
 - Fixed an issue where changing an empty value to a non-empty value using the Cache Editor UI didn't work. [PR #3508](https://github.com/microsoft/vscode-cmake-tools/pull/3508)
 - Fix CMakePresets inheritance for the `condition` field. [PR #3494](https://github.com/microsoft/vscode-cmake-tools/pull/3494)
-- Ensure that the output is cleared for `debugTarget` and `launchTarget` [#3489](https://github.com/microsoft/vscode-cmake-tools/issues/3489)
+- Ensure that the output is cleared for `debugTarget` and `launchTarget`. [#3489](https://github.com/microsoft/vscode-cmake-tools/issues/3489)
 - Fix the inheritance of the `environment` for CMakePresets. [#3473](https://github.com/microsoft/vscode-cmake-tools/issues/3473)
 - Removed an unnecessary `console.assert` [#3474](https://github.com/microsoft/vscode-cmake-tools/issues/3474)
 - Make sure we clear the output on builds due to test when `Clear output before build` is enabled. [#1179](https://github.com/microsoft/vscode-cmake-tools/issues/1179)

diff --git a/src/presetsController.ts b/src/presetsController.ts
@@ -392,6 +392,9 @@ export class PresetsController {
                 await this.addPresetAddUpdate(newPreset, 'configurePresets');
 
                 if (isMultiConfigGenerator) {
+                    // Ensure that we update our local copies of the PresetsFile so that adding the build preset happens as expected.
+                    await this.reapplyPresets();
+
                     const buildPreset: preset.BuildPreset = {
                         name: `${newPreset.name}-debug`,
                         displayName: `${newPreset.displayName} - Debug`,