Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update project outline on configure #3270

Merged
merged 13 commits into from
Sep 14, 2023

Conversation

vlavati
Copy link
Contributor

@vlavati vlavati commented Jul 29, 2023

This change addresses item #2823

This changes visible behavior of project outline

The following changes are proposed:

  • the project outline should contain projects/targets for all projects in multiroot workspaces
  • it should be possible to run/debug target from project outline in multiroot workspace

Other Notes/Information

On the image below there is a project outline for the "multi-root-UI". It contains projects for project-folder-2/subroot1, project-folder-2/subroot2, and project-folder-2.

изображение

If commands (Build/Launch) are called from context menu for the targets in multiroot workspace, it is needed to provide source directory of the project to choose correct project to execute cmake commands. (By default there is used active project)

@vlavati
Copy link
Contributor Author

vlavati commented Jul 29, 2023

@microsoft-github-policy-service agree

@gcampbell-msft gcampbell-msft self-assigned this Sep 5, 2023
src/extension.ts Outdated Show resolved Hide resolved
Copy link
Collaborator

@gcampbell-msft gcampbell-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall it looks pretty good, I just have a couple of questions and changes to be made.

@vlavati
Copy link
Contributor Author

vlavati commented Sep 8, 2023

Thanks for review, I hope it will be useful.

@gcampbell-msft
Copy link
Collaborator

@vlavati Thanks for the PR! I plan to test on Monday to confirm no breakages and then approve. Thanks!

gcampbell-msft
gcampbell-msft previously approved these changes Sep 12, 2023
Copy link
Collaborator

@gcampbell-msft gcampbell-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested changes and things seemed to work as expected.

@gcampbell-msft
Copy link
Collaborator

@benmcmorran Do you think the Windows test failure is due to these changes? It seems to be failing reliably but the failure itself is a "Resource is busy" error, which doesn't immediately strike me as something wrong with the code. Thanks!

@benmcmorran
Copy link
Member

@gcampbell-msft I just queued a test run for #3336. If that one passes then I suspect changes in this PR are causing the failure.

@benmcmorran
Copy link
Member

@gcampbell-msft Saw the same failure in the other PR, so I don't think we should consider it blocking here (but we should independently investigate why it started failing).

@gcampbell-msft
Copy link
Collaborator

gcampbell-msft commented Sep 14, 2023

@vlavati Hi! I've tested and all of the changes look good! One final thing before merging, could you please add a CHANGELOG.md entry? Add it to the 1.16 section in a new Improvements section. Optionally give yourself credit (follow the examples of the other entries in the changelog)

Once that is done we can merge!

@vlavati
Copy link
Contributor Author

vlavati commented Sep 14, 2023

@gcampbell-msft , @benmcmorran Regarding the failed tests on Windows, I suppose that it is because of the Terminal which blocks a current working directory. Some tests run "await cmakeProject.launchTarget();", which starts a terminal and a compiled target. But I did not find a way to check the exit status or wait until the Terminal is closed.

@gcampbell-msft
Copy link
Collaborator

Merging. I'm bypassing the failing Windows tests because we're seeing the same failure on other PRs and it's not related to this change.

@gcampbell-msft gcampbell-msft merged commit 1fb304b into microsoft:main Sep 14, 2023
3 of 4 checks passed
@vlavati vlavati deleted the Local/ReworkOutline branch September 15, 2023 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants