Don't run tests from testing sidebar on build failure #3506
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gcampbell-msft
requested review from
xisui-MSFT,
lukka,
benmcmorran and
snehara99
snehara99
approved these changes
Jan 2, 2024
snehara99
deleted the
dev/gcampbell/TestingSidebarDontTestOnBuildFailure
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #3366 by adding a return value to the
buildTestsmethod and uses that return value to assess whether we should run/debug the tests in therunTestHandleranddebugTestHandler. If the build fails, we output a log statement about why CTest wasn't run.