Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added inherit option and inheritDefault setting #3547

Merged
merged 2 commits into from
Jan 23, 2024

Conversation

snehara99
Copy link
Contributor

@snehara99 snehara99 commented Jan 22, 2024

This change addresses item #3452

This adds the inherit option to the cmake.options.advanced.statusBarVisibility setting, and also the cmake.options.advanced.inheritDefault setting. Here is the behaviour from the updated docs:

If a statusBarVisibility option is set to inherit, it will inherit the more general Cmake > Options : Status Bar Visibility setting if it is not set to hidden. If the more general Cmake > Options : Status Bar Visibility setting is set to hidden, then the inherit option will default to what is set in the inheritDefault setting. The default option for inheritDefault is visible.

These are now the default settings:

"cmake.options.statusBarVisibility": "hidden"
"cmake.options.advanced": {
    "build": {
        "statusBarVisibility": "inherit"
    },
    "launch": {
        "statusBarVisibility": "inherit"
    },
    "debug": {
        "statusBarVisibility": "inherit"
    }
}

@snehara99 snehara99 requested review from sinemakinci1, gcampbell-msft and benmcmorran and removed request for sinemakinci1 January 22, 2024 18:33
@snehara99 snehara99 self-assigned this Jan 22, 2024
@snehara99
Copy link
Contributor Author

@sinemakinci1 It would be helpful if you could review the docs changes I made, thanks!

@sinemakinci1
Copy link
Contributor

@snehara99 how does this change impact existing users who have configured their settings or did not configure their settings?

@snehara99
Copy link
Contributor Author

@snehara99 how does this change impact existing users who have configured their settings or did not configure their settings?

It shouldn't at all

@snehara99 snehara99 merged commit a8ba2f8 into main Jan 23, 2024
4 checks passed
@snehara99 snehara99 deleted the dev/snehara/add-inherit-setting branch January 23, 2024 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants