only set isUserPreset to true if it's defined in a user presets file
#4081
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelbjerking
approved these changes
Sep 23, 2024
|
@moyo1997 Ping for review, thanks! |
snehara99
reviewed
Oct 9, 2024
snehara99
previously approved these changes
Oct 9, 2024
snehara99
previously approved these changes
Oct 9, 2024
snehara99
approved these changes
Oct 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4059.
We were not showing presets as being available to select because we are determining that the preset is a user preset, when it really isn't. This is due to the fact that we were incorrectly setting
isUserPreset, we should check which file the configure preset was defined in.Test vsix here:
cmake-tools.zip