Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sanitize cmake.copyCompileCommands #4149

Merged
merged 3 commits into from
Nov 6, 2024
Merged

Sanitize cmake.copyCompileCommands #4149

merged 3 commits into from
Nov 6, 2024

Conversation

gcampbell-msft
Copy link
Collaborator

Fixes #3874.

Ensures that we're sanitizing the paths so that we accomplish two things:

  1. Parsing the file will work as expected because the file path is sanitized on all platforms
  2. Ensures that we sanitize all paths so that we can safely compare paths.

moyo1997
moyo1997 reviewed Nov 6, 2024
View reviewed changes
src/cmakeProject.ts Outdated Show resolved Hide resolved
moyo1997
moyo1997 previously approved these changes Nov 6, 2024
View reviewed changes
@gcampbell-msft gcampbell-msft enabled auto-merge (squash) November 6, 2024 19:01
@gcampbell-msft gcampbell-msft merged commit 31372d6 into main Nov 6, 2024
4 checks passed
@gcampbell-msft gcampbell-msft deleted the dev/gcampbell/SanitizeCopyCompileCommands branch November 6, 2024 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paulmaybee paulmaybee paulmaybee approved these changes

@moyo1997 moyo1997 moyo1997 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

copyCompileCommands to the original path still leaves a corrupted CDB on Windows
3 participants
@gcampbell-msft @paulmaybee @moyo1997