fix: re-classify configureOnOpen setting #4150
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@rzhao271 We feel confident with the state of that setting, does that mean that we can simply remove the tags for that setting? |
|
If it's not in an A/B experiment and it's ready to go, then you can remove all tags from the setting 🏁 |
gcampbell-msft
approved these changes
Oct 31, 2024
sinemakinci1
approved these changes
Oct 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
VS Code 1.95.0 is now out, and with it comes changes to the tagging system.
This PR changes the tags of the cmake.configureOnOpen setting.
For reference, the
previewtag indicates that the setting ID has been finalized and that the setting is almost stable, theonExPtag indicates that the setting can be referenced in an ExP experiment, and theexperimentaltag, which this PR removes, now denotes a WIP setting that could potentially be renamed or removed later. If a setting is stable and not controlled by an experiment, it does not need any of these tags.Let me know if the tags I suggest in the diff are inaccurate.