Undo detached. (#9026)

* Undo detached. * Update changelog.
microsoft · Mar 15, 2022 · a07c8fd · a07c8fd
1 parent e41ead2
commit a07c8fd
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 5 deletions.
diff --git a/Extension/CHANGELOG.md b/Extension/CHANGELOG.md
@@ -1,13 +1,15 @@
 # C/C++ for Visual Studio Code Change Log
 
-## Version 1.9.4-debug: March 11, 2022
+## Version 1.9.4-debug: March 14, 2022
 * This is a debug build for Windows x64 intended to be used to get assertion failure information for bug [#8851](https://github.com/microsoft/vscode-cpptools/issues/8851).
 
-## Enhancement
+## Enhancements
+* Reserved identifiers with characters that match typed characters in the correct order but not contiguously are initially filtered in the auto-completion list. Doing a `ctrl` + `space` in the same location will show all auto-complete suggestions. [#4939](https://github.com/microsoft/vscode-cpptools/issues/4939)
 * Show "Catastrophic error" during tag parsing with an Error logging severity and report the number of occurrences via telemetry. [#9013](https://github.com/microsoft/vscode-cpptools/issues/9013)
 
-## Bug Fix
+## Bug Fixes
 * Fix temp files randomly not getting deleted on Windows with a `C_Cpp.loggingLevel` of `Warning` or greater. [#9008](https://github.com/microsoft/vscode-cpptools/issues/9008)
+* Fix mingw clang being detected as gcc. [#9024](https://github.com/microsoft/vscode-cpptools/issues/9024)
 
 ## Version 1.9.3: March 9, 2022
 ### New Feature

diff --git a/Extension/src/LanguageServer/client.ts b/Extension/src/LanguageServer/client.ts
@@ -1076,8 +1076,10 @@ export class DefaultClient implements Client {
         }
         const serverName: string = this.getName(this.rootFolder);
         const serverOptions: ServerOptions = {
-            run: { command: serverModule, options: { detached: true } },
-            debug: { command: serverModule, args: [serverName], options: { detached: true } }
+            // Running detached would be preferred; however, that causes cpptools-srv to create a console window
+            // on Windows and that can't seem to be suppressed without suppressing assertion dialog boxes.
+            run: { command: serverModule, options: { detached: false } },
+            debug: { command: serverModule, args: [serverName], options: { detached: false } }
         };
 
         // Get all the per-workspace settings.