-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add keyboard support for Inline Macro. #11261
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michelleangela
previously approved these changes
Jul 28, 2023
…om/Microsoft/vscode-cpptools into seanmcm/inlineMacroKeyboardSupport
bobbrow
reviewed
Aug 3, 2023
bobbrow
reviewed
Aug 3, 2023
michelleangela
previously approved these changes
Aug 16, 2023
Colengms
previously approved these changes
Aug 18, 2023
…om/Microsoft/vscode-cpptools into seanmcm/inlineMacroKeyboardSupport
sean-mcmanus
dismissed stale reviews from Colengms and michelleangela
via
August 30, 2023 22:54
eb51909
@sean-mcmanus is this ready to check in? |
bobbrow
approved these changes
Sep 8, 2023
Colengms
approved these changes
Sep 8, 2023
Yes |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on what the TypeScript extensions does, since I'm doing something similar for Extract Function. Fixes #11260 .
The keyboard shortcut can be change/replaced/etc. (see https://code.visualstudio.com/docs/editor/refactoring ).
Also, normalized loc strings to use
.
instead of_
and fixed spelling errors in string types (9 misspelled words).