Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add keyboard support for Inline Macro. #11261

Merged
merged 26 commits into from
Sep 11, 2023

Conversation

sean-mcmanus
Copy link
Contributor

@sean-mcmanus sean-mcmanus commented Jul 28, 2023

Based on what the TypeScript extensions does, since I'm doing something similar for Extract Function. Fixes #11260 .

The keyboard shortcut can be change/replaced/etc. (see https://code.visualstudio.com/docs/editor/refactoring ).

image

Also, normalized loc strings to use . instead of _ and fixed spelling errors in string types (9 misspelled words).

@sean-mcmanus sean-mcmanus requested a review from a team July 28, 2023 02:46
michelleangela
michelleangela previously approved these changes Jul 28, 2023
@sean-mcmanus sean-mcmanus added this to the 1.18.0 milestone Aug 11, 2023
michelleangela
michelleangela previously approved these changes Aug 16, 2023
Colengms
Colengms previously approved these changes Aug 18, 2023
@bobbrow
Copy link
Member

bobbrow commented Sep 8, 2023

@sean-mcmanus is this ready to check in?

@sean-mcmanus
Copy link
Contributor Author

@sean-mcmanus is this ready to check in?

Yes

@sean-mcmanus sean-mcmanus merged commit 2cc55ea into main Sep 11, 2023
4 checks passed
@sean-mcmanus sean-mcmanus deleted the seanmcm/inlineMacroKeyboardSupport branch September 11, 2023 16:56
@github-actions github-actions bot locked and limited conversation to collaborators Oct 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Inline Macro requires invoking hover first
4 participants