Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update walkthrough text for the customize debugging step. #11580

Merged
merged 1 commit into from
Oct 25, 2023
Merged

Update walkthrough text for the customize debugging step. #11580

merged 1 commit into from
Oct 25, 2023

Conversation

spebl
Copy link
Contributor

@spebl spebl commented Oct 24, 2023

Implementation of the proposed text change mentioned in #11320.

@spebl spebl requested a review from a team October 24, 2023 23:38
@spebl spebl linked an issue Oct 24, 2023 that may be closed by this pull request
Walkthrough Improvement: Updated wording for "Customize Debugging" step #11320
Closed
sean-mcmanus
sean-mcmanus requested changes Oct 25, 2023
View reviewed changes
Copy link
Contributor

@sean-mcmanus sean-mcmanus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The previous text didn't mention "C++ file" -- what about C users who are debugging? Should we use C or C++ file?

@sean-mcmanus
Copy link
Contributor

The previous text didn't mention "C++ file" -- what about C users who are debugging? Should we use C or C++ file?

Oh, I see, it's in the context of the C++ focused walkthrough.

@spebl spebl merged commit 6f80226 into main Oct 25, 2023
4 checks passed
@spebl spebl deleted the dev/spebl/customizedebugging branch October 25, 2023 21:56
@github-actions github-actions bot locked and limited conversation to collaborators Dec 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@AlexandraKemperMS AlexandraKemperMS AlexandraKemperMS left review comments

@sean-mcmanus sean-mcmanus sean-mcmanus approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Walkthrough Improvement: Updated wording for "Customize Debugging" step
3 participants
@spebl @sean-mcmanus @AlexandraKemperMS