Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open the modified header for 'Extract to function'. #11670

Merged

Conversation

sean-mcmanus
Copy link
Contributor

@sean-mcmanus sean-mcmanus commented Nov 13, 2023

Fixes #11669 (formatting not working if the header wasn't open). Also, fix the issue where the header would change and never open (if files.refactoring.autoSave were enabled), so users may not realize the file had change (unless they viewed a source control diff).

@sean-mcmanus sean-mcmanus requested a review from a team November 13, 2023 23:01
@sean-mcmanus sean-mcmanus merged commit 5325b37 into main Nov 13, 2023
4 checks passed
@sean-mcmanus sean-mcmanus deleted the seanmcm/fixExtractToFunctionHeaderNotOpeningOrFormatting branch November 13, 2023 23:13
@github-actions github-actions bot locked and limited conversation to collaborators Dec 29, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

'Extract to function' header isn't formatted if the header file is not already open
2 participants