Fix various NPEs caused by dynamically computed method calls #1704
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ljfa-ag
requested review from
chagong,
testforstephen and
wenytang-ms
as code owners
|
@microsoft-github-policy-service agree |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Groovy method calls where the method name is an interpolated string (for example
"${foo}"(...)) are currently causing NPEs in various places. Autocompletion doesn't work in the entire file when such a call is used anywhere in a build.gradle file. The problem is that "MethodCallExpression.getMethodAsString()" returns null for these dynamic method calls.I have mostly moved constant strings to the front of equals comparisons to avoid the NPEs. In some cases I have replaced "getMethodAsString()" by "getMethod().getText()", which is not null.
This fixes #1562.