including @ in selection #20562
Merged
including @ in selection #20562
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aasimkhan30
requested review from
Benjin,
allancascante,
caohai,
kburtram,
laurenastrid1,
lewis-sanchez,
manujoseph85 and
ssreerama
as code owners
PR Changes
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #20562 +/- ##
=======================================
Coverage 64.83% 64.83%
=======================================
Files 210 210
Lines 19443 19443
Branches 2472 2472
=======================================
Hits 12606 12606
Misses 6752 6752
Partials 85 85 🚀 New features to boost your workflow:
|
kburtram
previously approved these changes
Nov 18, 2025
Member
kburtram
left a comment
kburtram
left a comment
There was a problem hiding this comment.
I didn't try to parse the regex but if you copied from ADS they should be good
laurenastrid1
previously approved these changes
Nov 19, 2025
lewis-sanchez
previously approved these changes
Nov 19, 2025
aasimkhan30
dismissed stale reviews from lewis-sanchez, laurenastrid1, and kburtram
via
da45d01
lewis-sanchez
approved these changes
Dec 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes: #19545
Got the regexes from ADS. https://github.com/microsoft/azuredatastudio/blob/ee52915d1017a5ecaaafc71cc890d7621e499c91/src/vs/editor/common/core/wordHelper.ts#L10-L12
Code Changes Checklist
npm run test)Reviewers: Please read our reviewer guidelines