chore: simplify SlickGrid formatter #20702
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Template – vscode-mssql
Description
a simple follow-up PR to previous PR #20694, most specifically a follow-up to this comment
it merges 3 DOM elements into a single one since they all follow roughly the same logic.
Code Changes Checklist
npm run test)Reviewers: Please read our reviewer guidelines
Future Code Review Questions
@lewis-sanchez I see that you added the
editCommandHandlerwhich is typically used for Undo Edit, but in your case it looks like you provided your own way of dealing with Undo... so in that case the use ofeditCommandHandleris totally irrelevant becauseeditCommand.execute();is already the default code execution within SlickGrid when no edit handler is provided (see here), which mean that you could remove this handler without affecting the code (unless you really want to use its Undo feature later on?)vscode-mssql/extensions/mssql/src/reactviews/pages/TableExplorer/TableDataGrid.tsx
Lines 355 to 357 in 55a828d