Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vscode web incorrectly opens uri resolved from IExternalUriResolver #175164

Open
jeanp413 opened this issue Feb 22, 2023 · 4 comments · May be fixed by #175166
Open

vscode web incorrectly opens uri resolved from IExternalUriResolver #175164

jeanp413 opened this issue Feb 22, 2023 · 4 comments · May be fixed by #175166
Assignees
Labels
feature-request Request for new features or functionality opener Opener service issues uri
Milestone

Comments

@jeanp413
Copy link
Contributor

  • VS Code Version: stable and from sources

This is related to #85930 and #140907, there's already a TODO about this in openerService but there's no workaround like in the other cases as the exposed interface only accepts and returns an URI

Steps to repro gitpod-io/gitpod#16494

cc @jrieken

@jeanp413 jeanp413 linked a pull request Feb 22, 2023 that will close this issue
@jrieken jrieken assigned jrieken and unassigned bhavyaus Feb 23, 2023
@jrieken jrieken added uri opener Opener service issues labels Mar 31, 2023
@jrieken jrieken added the feature-request Request for new features or functionality label Dec 5, 2023
@vscodenpa vscodenpa added this to the Backlog Candidates milestone Dec 5, 2023
@vscodenpa
Copy link

This feature request is now a candidate for our backlog. The community has 60 days to upvote the issue. If it receives 20 upvotes we will move it to our backlog. If not, we will close it. To learn more about how we handle feature requests, please see our documentation.

Happy Coding!

@bpasero
Copy link
Member

bpasero commented Dec 5, 2023

@jeanp413 can you clarify if there is a bug or feature request associated to VS Code that will improve VS Code or is this mainly to fix an upstream issue by an unsupported fork of VS Code? Asking because I also see a PR linked to this issue which I would not accept unless it also addresses a real issue in VS Code today.

@bpasero bpasero added the info-needed Issue requires more information from poster label Dec 5, 2023
@jeanp413
Copy link
Contributor Author

jeanp413 commented Dec 6, 2023

@bpasero It's an actual issue of vscode, see #85930 and #140907 as an example, 140907 fix got reverted because it broke vscode and a workaround was pushed instead for the extension api, this issue is about the embedder api

@bpasero bpasero removed the info-needed Issue requires more information from poster label Dec 6, 2023
@bpasero bpasero assigned mjbvz and unassigned bpasero Dec 6, 2023
@vscodenpa
Copy link

This feature request has not yet received the 20 community upvotes it takes to make to our backlog. 10 days to go. To learn more about how we handle feature requests, please see our documentation.

Happy Coding!

@jrieken jrieken modified the milestones: Backlog Candidates, Backlog Jan 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request Request for new features or functionality opener Opener service issues uri
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants