Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow IExternalUriResolver to return URI or URL #175166

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

jeanp413
Copy link
Contributor

Fixes #175164

Allow IExternalUriResolver to return URI or URL, this is backwards compatible for current web embedders and will allow to properly open a resolved uri that currently fails if we return a URI

cc @jrieken

@jeanp413 jeanp413 changed the title IExternalUriResolver can return URI or URL Allow IExternalUriResolver to return URI or URL Feb 22, 2023
@alexr00 alexr00 assigned mjbvz and unassigned alexr00 Feb 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

vscode web incorrectly opens uri resolved from IExternalUriResolver
5 participants