Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cmd-Click doesn't work on JSDoc {@link URL|LinkText} format #225513

Open
jedwards1211 opened this issue Aug 13, 2024 · 0 comments · May be fixed by #232460
Open

Cmd-Click doesn't work on JSDoc {@link URL|LinkText} format #225513

jedwards1211 opened this issue Aug 13, 2024 · 0 comments · May be fixed by #232460
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug javascript JavaScript support issues typescript Typescript support issues

Comments

@jedwards1211
Copy link
Contributor

jedwards1211 commented Aug 13, 2024

Does this issue occur when all extensions are disabled?: Yes/No

  • VS Code Version:
  • OS Version:

Steps to Reproduce:

  1. Create a .ts file containing
    /**
     * {@link https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Promise/withResolvers|Promise.withResolvers}
     */
    This is one of the valid ways of providing link text according to https://jsdoc.app/tags-inline-link.
  2. Cmd-Click (or Windows equivalent) on the URL
  3. VSCode opens https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Promise/withResolvers%7CPromise.withResolvers, instead of https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Promise/withResolvers

When I tried {@link http://www.google.com|Google}, Cmd-Clicking on the link doesn't open anything, and logs

2024-08-13 12:04:55.265 [error] TypeError: Invalid URL
	at new URL (node:internal/url:797:36)
	at Object.canOpenExternalUri (/Applications/Visual Studio Code.app/Contents/Resources/app/extensions/simple-browser/dist/extension.js:1:6134)

Fortunately I can use [Link Text]{@link URL} format, but I expected VSCode to support any valid @link format.

@mjbvz mjbvz added bug Issue identified by VS Code Team member as probable bug typescript Typescript support issues javascript JavaScript support issues labels Sep 23, 2024
@duncpro duncpro linked a pull request Oct 29, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue identified by VS Code Team member as probable bug javascript JavaScript support issues typescript Typescript support issues
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants