Vertical pipe characters should terminate URLs #232460
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The vertical pipe character
|is neither reserved nor unreserved under RFC 3986: Uniform Resource Identifiers and therefore it cannot appear within a URI.However,
linkComputer.tsdoes not list the vertical pipe character underFORCE_TERMINATION_CHARACTERS.This makes VSCode's link-opening feature unusable in some circumstances since the vertical bar gets erroneously included in the URL, rendering it invalid. See #225513 for one example.
Note that this issue was reported earlier in #86358, and fixed improperly in this commit.
This pull request adds the vertical bar to the
FORCE_TERMINATION_CHARACTERS, fixing the issue. It also reverts the change made in the other commit.Testing
See the test case provided in #225513. After this commit VSCode behaves correctly.
Closes #225513