Skip to content

Test: Preserve recorded GitHub titles in issue and pull-request pills #335877

Description

@chryw

Refs: #335387, #335383

Complexity: 1

Authors: Cherry Wang (@chryw)


Context

Agent Host sessions can contain GitHub issue and pull-request artifacts with recorded titles. Verify that the first-level Issues and Pull Requests pills expose the referenced number and title and remain usable.

Related follow-up: #335583, #335448. The richer preview proposed there is out of scope; this TPI covers the shipped behavior from #335387 only.

Setup

  • Use an Insiders build containing sessions: preserve recorded GitHub titles in pills #335387.
  • Open the microsoft/vscode repository in an Agents Window.
  • Start a new session against that workspace.
  • Submit the following prompt. It records two issues and two pull requests so both collection pills are created.
Use only the add_artifact_or_reference tool. Do not call shell, git, create_session, or any other tool. Call add_artifact_or_reference exactly once with this exact input:

{"items":[{"type":"issue","label":"Agent Window issue pill discards the recorded issue title","isArtifact":true,"link":"https://github.com/microsoft/vscode/issues/335383"},{"type":"issue","label":"Show rich GitHub issue previews with title and rendered body in hovers","isArtifact":true,"link":"https://github.com/microsoft/vscode/issues/335448"},{"type":"pullRequest","label":"sessions: preserve recorded GitHub titles in pills","isArtifact":true,"link":"https://github.com/microsoft/vscode/pull/335387"},{"type":"pullRequest","label":"sessions: add rich GitHub reference previews","isArtifact":true,"link":"https://github.com/microsoft/vscode/pull/335583"}]}

Do not repeat the URLs as Markdown links. After the tool succeeds, reply only: References recorded.

Test

Agents Window

  1. Wait for the response to finish and verify that separate 2 Issues and 2 Pull Requests pills appear.
  2. Open each pill and verify that the first-level popup contains identifiable rows:
    • #335383 and Agent Window issue pill discards the recorded issue title
    • #335448 and Show rich GitHub issue previews with title and rendered body in hovers
    • #335387 and sessions: preserve recorded GitHub titles in pills
    • #335583 and sessions: add rich GitHub reference previews
    • #335387 and sessions: preserve recorded GitHub titles in pills
    • #335583 and sessions: add rich GitHub reference previews
  3. Verify that a long title remains readable when space is constrained, without hiding the GitHub number or row actions.
  4. Hover or keyboard-focus a row and verify that the full title and GitHub URL remain available. Do not evaluate the content or layout of the follow-up rich preview.
  5. Activate each row with Enter and verify that it opens the exact issue or pull request.
  6. In Screen Reader Optimized mode, verify that each row announces the resource type, number, and title.

Additional coverage

  1. Repeat the number-and-title checks in regular editor/panel chat.
  2. If live GitHub lookup is unavailable, verify that the recorded titles remain visible.
  3. If an artifact has no recorded or live title, verify that it falls back to the GitHub number.

Visual checks

  • Check that the number and title are visually associated and readable.
  • Check a narrow window, dark/light themes, and high contrast for truncation, focus, contrast, and row alignment.
  • Check that the Agents Window and regular editor/panel chat are consistent.

Expected

Each populated first-level row exposes the GitHub number and title, remains readable and actionable, and preserves the expected fallback when live metadata is unavailable. Activating a row opens the exact referenced issue or pull request.

Reporting

For failures, include:

  • VS Code version/build and operating system;
  • whether the test was performed in the Agents Window or regular editor/panel chat;
  • whether live GitHub title lookup was available;
  • whether the artifact was an issue or pull request;
  • the observed and expected labels; and
  • screenshots for visual or layout issues, including the theme, surface, and approximate viewport size;
  • accessibility details; and
  • logs where relevant.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    Projects

    No projects

      Milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions