#163967 css aliases #197033
Open
#163967 css aliases #197033
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feat(css aliases): added scss.alias.paths Provides definitions and constraints to the settings
|
@microsoft-github-policy-service agree |
This was referenced Oct 30, 2023
fix(package.nls.json): amended key and description
BartBartek
approved these changes
Feb 13, 2024
|
Since microsoft/vscode-css-languageservice#368 is merged, are there any blockers for merging this? |
|
What are valid paths? Relative, absolute? Resolved against what? |
bwojtyca
approved these changes
May 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #163967: [css] Custom aliases in CSS file resolution
In conjunction with Pull Request #368
Functionality
Main functionality is in the aforementioned pull request. The changes in this pull request allow the user to specify the alias settings that are to be consumed by the css-language-service to allow for ctrl-click file link navigation for aliased imports within CSS and SCSS files.
Changes
Package.json:
Added an 'alias.path' object, for both css and scss, that allows a user to specify an alias and an associated path. Object has pattern constraints to ensure correct syntax and mirroring the behaviour of alias settings in a tsconfig.json file (under 'compiler.paths').
Package.nls.json:
Added the associated tool tip descriptions to guide the user on using the settings.