Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

don't show output items if they are empty #216844

Merged
merged 11 commits into from
Jun 28, 2024
Merged

don't show output items if they are empty #216844

merged 11 commits into from
Jun 28, 2024
+261 −39

Conversation

amunger
Copy link
Contributor

@amunger amunger commented Jun 21, 2024 •
edited
Loading

@amunger
Copy link
Contributor Author

amunger commented Jun 21, 2024

checking the innerText === '' doesn't really make sense since all plots/images have empty inner text.
checking if the element has any height would work, except that the children of the element are padded and therefore always have a significant height.

@amunger amunger requested a review from rebornix June 28, 2024 18:55
@amunger amunger marked this pull request as ready for review June 28, 2024 20:29
@VSCodeTriageBot VSCodeTriageBot added this to the June 2024 milestone Jun 28, 2024
@amunger amunger closed this Jun 28, 2024
@amunger amunger reopened this Jun 28, 2024
@amunger amunger enabled auto-merge (squash) June 28, 2024 21:00
@amunger amunger merged commit 032c1b7 into main Jun 28, 2024
9 checks passed
@amunger amunger deleted the aamunger/emptyOutput branch June 28, 2024 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rebornix rebornix rebornix approved these changes

Assignees

@amunger amunger

Labels
None yet
Projects
None yet
Milestone
June 2024
3 participants
@amunger @rebornix @VSCodeTriageBot