fix: #232226 - Allow margin:0 in markdownRenderer #232228
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… can override the 4px bottom margin that is added to every span in the Hover
Kylayese
approved these changes
Jan 3, 2025
|
Hi @mjbvz is there any thing i can do to help move this along? Please let me know if you need anything from me! Thank you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #232226
As described in the issue, we give extension authors the option to remove the bottom margin that is added to every span in the Hover. This is a nondestructive change that maintains the existing behavior and makes the
margin:0opt-in for those who may need it.Before:
After:
