add toggle details focus for terminal suggest widget#238022
add toggle details focus for terminal suggest widget#238022meganrogge merged 26 commits intomainfrom
Conversation
|
I figured parts 2 and 3 of the problem out! The key was the terminal wasn't receiving focus like it should've been when the list was focused. Screen.Recording.2025-01-15.at.10.10.57.PM.mov |
|
in the morning, i'll try to see how the editor handles this. |
|
Edit: figured that out too. Using |
…nal.suggest.contribution.ts
|
edit: nooo, it's not working. I had modified a |
|
the only way I can get this to work is via setting the precondition to be the opposite of the editor's. since these are the only commands with this keybinding, maybe that's fine 🤷🏼♀️ |
|
fixed an additional problem where the widget wouldn't close on blur of the details and now is working really nicely demo.mov |
|
weird that this didn't get merged |
|
Only change from yesterday is making sure it hides when the terminal is clicked - to match editor's behavior |
b4d120c to
4496961
Compare


want to support toggling focus between the suggest list and details for screen reader support.
fixes #238004