Expose shell's environment - fish shell #240971
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
TODO: Should probably update Python environment extension before merging this in: microsoft/vscode-python-environments#155 |
|
@meganrogge I tried to update the terminal suggest code to conform to new api shape (added the isTrusted field and env is now accessible via |
Tyriar
requested changes
Feb 19, 2025
Tyriar
requested changes
Feb 20, 2025
src/vs/workbench/contrib/terminal/common/scripts/shellIntegration-bash.sh
Show resolved
Hide resolved
Co-authored-by: Daniel Imms <[email protected]>
Tyriar
approved these changes
Feb 20, 2025
anthonykim1
added a commit
to microsoft/vscode-python-environments
that referenced
this pull request
Feb 20, 2025
Adding isTrusted field as part of shell env api, meaning the shape would change a bit. Accessing shell env would be `.env.value` instead of `.env`. Trying to prevent breaking where this api is already being used, so that I can safely merge: microsoft/vscode#240971
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #227467 for fish shell.
Also adding isTrusted and changing things here and there in order to support shell env for fish without nonce