Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

append activeEditorState when in screen reader mode by default #241229

Merged
merged 4 commits into from
Feb 20, 2025

Conversation

meganrogge
Copy link
Contributor

Also updates the a11y help dialog to indicate how to disable this

fix #239880

@meganrogge meganrogge self-assigned this Feb 19, 2025
@meganrogge meganrogge requested a review from bpasero February 19, 2025 17:20
@meganrogge meganrogge added this to the February 2025 milestone Feb 19, 2025
Copy link
Member

@bpasero bpasero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only minor feedback.

connor4312
connor4312 previously approved these changes Feb 20, 2025
@meganrogge meganrogge enabled auto-merge (squash) February 20, 2025 01:24
bpasero
bpasero previously approved these changes Feb 20, 2025
@meganrogge meganrogge dismissed stale reviews from bpasero and connor4312 via 9174836 February 20, 2025 15:33
@meganrogge meganrogge merged commit 55be3d7 into main Feb 20, 2025
8 checks passed
@meganrogge meganrogge deleted the merogge/active-editor-state branch February 20, 2025 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consider including activeEditorState in window.title by default for screen reader users
4 participants