handle folder references in prompt files #241271
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
connor4312
reviewed
Feb 20, 2025
| // validate that the cancellation was not yet requested | ||
| assert( | ||
| !cancellationToken?.isCancellationRequested, | ||
| new CancellationError(), |
There was a problem hiding this comment.
Creating an error, which involves capturing a stacktrace synchronously, is one of the more costly things one can do in JS. Looks like this isn't a super hot path but it would be good to avoid this pattern (creating an error unnecesarily) proliferating too much.
There was a problem hiding this comment.
Browser engines optimize these cases pretty well so I would not worry too much about it. On the other hand, this particular case is easy to improve, so will do that in a subsequent PR 👍
connor4312
reviewed
Feb 20, 2025
...vs/workbench/contrib/chat/common/promptSyntax/contentProviders/filePromptContentsProvider.ts
Show resolved
Hide resolved
connor4312
approved these changes
Feb 20, 2025
legomushroom
deleted the
legomushroom/prompts/handle-folder-references
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For https://github.com/microsoft/vscode-copilot/issues/13091.
The PR adds logic to handle folder references inside prompt files. For now it ignores these references - does not provide document links for them(md extension already does that better) and not sending the references to the copilot (not useful).