Skip to content

fix languages.getDiagnostics() problem-matchers diagnostics duplication #290278

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Dmitriy Vasyura (dmitrivMS) merged 1 commit into from
Aug 17, 2026
Merged

fix languages.getDiagnostics() problem-matchers diagnostics duplication #290278

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 2 additions & 8 deletions src/vs/workbench/api/browser/mainThreadDiagnostics.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,14 +58,8 @@ export class MainThreadDiagnostics implements MainThreadDiagnosticsShape {
const data: [UriComponents, IMarkerData[]][] = [];
for (const resource of resources) {
const allMarkerData = this._markerService.read({ resource, ignoreResourceFilters: true });
if (allMarkerData.length === 0) {
data.push([resource, []]);
} else {
const foreignMarkerData = allMarkerData.filter(marker => marker?.origin !== this.extHostId);
if (foreignMarkerData.length > 0) {
data.push([resource, foreignMarkerData]);
}
}
const markerData = allMarkerData.filter(marker => marker.origin !== this.extHostId);
data.push([resource, markerData]);
}
if (data.length > 0) {
this._proxy.$acceptMarkersChange(data);
Expand Down
6 changes: 5 additions & 1 deletion src/vs/workbench/api/common/extHostDiagnostics.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -363,7 +363,11 @@ export class ExtHostDiagnostics implements ExtHostDiagnosticsShape {
}

for (const [uri, markers] of data) {
this._mirrorCollection.set(URI.revive(uri), markers.map(converter.Diagnostic.to));
if (markers.length === 0) {
this._mirrorCollection.delete(URI.revive(uri));
} else {
this._mirrorCollection.set(URI.revive(uri), markers.map(converter.Diagnostic.to));
}
}
}
}
Loading