Suggest TypeScript 7 for users with no plugins enabled - #327208
Closed
Daniel Rosenwasser (DanielRosenwasser) wants to merge 3 commits into
Closed
Suggest TypeScript 7 for users with no plugins enabled#327208Daniel Rosenwasser (DanielRosenwasser) wants to merge 3 commits into
Daniel Rosenwasser (DanielRosenwasser) wants to merge 3 commits into
Conversation
…e no TSServer plugin contributors.
Copilot started reviewing on behalf of
Daniel Rosenwasser (DanielRosenwasser)
July 23, 2026 21:38
View session
Contributor
There was a problem hiding this comment.
Pull request overview
Broadens the TypeScript 7 preview suggestion to users without incompatible TSServer plugins.
Changes:
- Gates the suggestion on enabled plugins, exempting Copilot.
- Renames the experimentation treatment.
- Recognizes current stable and nightly TypeScript 7 extensions.
Show a summary per file
| File | Description |
|---|---|
suggestNativePreview.ts |
Adds plugin-based eligibility gating. |
typescriptServiceClient.ts |
Exports the Copilot extension ID. |
extension.ts |
Passes the plugin manager to suggestion logic. |
experimentationService.ts |
Updates the treatment variable type. |
useTsgo.ts |
Adds current TypeScript 7 extension IDs. |
Review details
- Files reviewed: 5/5 changed files
- Comments generated: 0
- Review effort level: Medium
| experimentationService: ExperimentationService, | ||
| pluginManager: PluginManager, | ||
| ): Promise<void> { | ||
| if (context.globalState.get<boolean>(suggestNativePreviewStorageKey)) { |
Member
Author
There was a problem hiding this comment.
We're specifically using the same storage key so that if you got this prompt in the past, we won't bug you again.
But I'm now thinking that maybe we should respect the key and not show anything, but set a separate one for new users instead.
Daniel Rosenwasser (DanielRosenwasser)
deleted the
suggestTs7IfNoPlugins
branch
September 9, 2026 22:30
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.