Fix missing leading whitespace on custom dialogs - #327547
Merged
SteVen Batten (sbatten) merged 2 commits intoJul 27, 2026
Merged
Conversation
Don't remove leading whitespace on custom dialogs
SteVen Batten (sbatten)
enabled auto-merge (squash)
July 26, 2026 20:42
SteVen Batten (sbatten)
requested a review
from Benjamin Christopher Simmonds (benibenj)
July 26, 2026 20:42
Contributor
There was a problem hiding this comment.
Pull request overview
Preserves leading whitespace in custom dialog detail text.
Changes:
- Applies
white-space: pre-wrapto dialog details.
Show a summary per file
| File | Description |
|---|---|
src/vs/base/browser/ui/dialog/dialog.css |
Preserves whitespace while retaining text wrapping. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 1
- Review effort level: Medium
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Benjamin Christopher Simmonds (benibenj)
approved these changes
Jul 27, 2026
Giuseppe Cianci (Giuspepe)
approved these changes
Jul 27, 2026
SteVen Batten (sbatten)
deleted the
agents/fix-leading-whitespace-custom-dialog
branch
July 27, 2026 10:04
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Don't remove leading whitespace on custom dialogs. note that macos native dialogs don't preserve the whitespace but I don't see a reason we shouldn't support this in our custom dialogs
fixes #128233