Gate tip.planMode on the openPlan command being registered

[Copilot]

Description

Clicking the "Plan agent" link in the tip.planMode chat tip threw command 'workbench.action.chat.openPlan' not found.

workbench.action.chat.openPlan is not a built-in command — "Plan" is a custom chat mode, and its open-command is registered dynamically by ModeActionsContribution only when a Plan mode is present in the focused widget. The tip's when clause (chatModeName != 'Plan') is true for everyone not currently in Plan mode, including users with no Plan mode at all, so the tip and its dead command link were shown even though the command was never registered.

Changes

• chatTipCatalog.ts — Added optional requiresCommands?: readonly string[] to ITipDefinition; set requiresCommands: ['workbench.action.chat.openPlan'] on tip.planMode.
• chatTipService.ts — _isEligible now skips a tip when any of its requiresCommands is absent from CommandsRegistry.
• chatTipService.test.ts — Register openPlan in setup() (mirrors "Plan mode available"); added a test asserting tip.planMode is never shown when the command is unregistered.

if (tip.requiresCommands?.some(commandId => !CommandsRegistry.getCommand(commandId))) {
    return false;
}

This is reusable: any tip linking to an optionally-available command can guard itself the same way to avoid "command not found" errors.

• Fixes [Error] unhandlederror-command 'workbench.action.chat.openPlan' not found #328231

[Copilot]

Pull request overview

Prevents the Plan mode tip from linking to an unavailable command.

Changes:

• Adds required-command metadata to chat tips.
• Filters tips using command registration.
• Tests Plan tip exclusion when its command is unavailable.

Show a summary per file

File	Description
chatTipCatalog.ts	Marks the Plan tip as requiring openPlan.
chatTipService.ts	Checks required commands during eligibility.
chatTipService.test.ts	Covers registered and unavailable Plan commands.

Review details

• Files reviewed: 3/3 changed files
• Comments generated: 1
• Review effort level: Medium

[Megan Rogge (meganrogge)]

Copilot resolve the merge conflicts in this pull request

[Copilot]

Copilot resolve the merge conflicts in this pull request

Resolved in 4c591ec.