fix: show Preview as icon in turn changes summary - #328582
Open
Akshat Anand (cipheraxat) wants to merge 7 commits into
Open
fix: show Preview as icon in turn changes summary#328582Akshat Anand (cipheraxat) wants to merge 7 commits into
Akshat Anand (cipheraxat) wants to merge 7 commits into
Conversation
The per-row Preview control was shipped as a blue text link despite the original labelless/icon intent. Render Codicon.openPreview via ActionBar and style it as a toolbar icon. Fixes microsoft#328520
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes turn-change previews to display as icon-only actions while retaining accessible labels.
Changes:
- Adds the
openPreviewicon and icon-only rendering. - Applies standard toolbar icon styling.
- Adds unit and component-fixture coverage.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
chatTurnPills.fixture.ts |
Updates fixture documentation. |
chatTurnPills.test.ts |
Tests preview action creation and execution. |
chat.css |
Styles preview actions as toolbar icons. |
chatTurnPills.ts |
Extracts and creates icon-based preview actions. |
chatTurnPillsPart.ts |
Uses the extracted action factory. |
chatChangesSummaryPart.ts |
Renders row actions as icons without labels. |
|
Odoslané z iPhonuDňa 1. 8. 2026 o 22:35 užívateľ Copilot ***@***.***> napísal:
@Copilot commented on this pull request.
Pull request overview
Fixes turn-change previews to display as icon-only actions while retaining accessible labels.
Changes:
Adds the openPreview icon and icon-only rendering.
Applies standard toolbar icon styling.
Adds unit and component-fixture coverage.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
File
Description
chatTurnPills.fixture.ts
Updates fixture documentation.
chatTurnPills.test.ts
Tests preview action creation and execution.
chat.css
Styles preview actions as toolbar icons.
chatTurnPills.ts
Extracts and creates icon-based preview actions.
chatTurnPillsPart.ts
Uses the extracted action factory.
chatChangesSummaryPart.ts
Renders row actions as icons without labels.
—Reply to this email directly, view it on GitHub, or unsubscribe.Triage notifications, keep track of coding agent tasks and review pull requests on the go with GitHub Mobile for iOS and Android. Download it today!
You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>
|
Michael Lively (Yoyokrazy)
assigned
Benjamin Christopher Simmonds (benibenj) and unassigned
Michael Lively (Yoyokrazy)
Contributor
|
there are merge conflicts, can you resolve them. Also please provide a before and after screenshot |
Resolve conflicts in chatTurnPillsPart imports, chat.css comment, and chatTurnPills fixture naming after main's external-preview refactor. Keep icon-only Preview row actions from this branch.
Requested on the PR review. Can drop these assets after merge.
Contributor
Author
|
Benjamin Christopher Simmonds (@benibenj) merge conflicts with Before / after for the Preview control in the expanded turn-changes list: BeforeBlue Preview text link (from #328520):
AfterSame row,
Happy to drop the |
…es-preview-icon # Conflicts: # src/vs/workbench/contrib/chat/browser/widget/chatContentParts/chatTurnPillsPart.ts # src/vs/workbench/contrib/chat/test/browser/widget/chatTurnPills.test.ts
Screenshots stay in the PR comment; they should not land in vscode.
Contributor
Author
|
Benjamin Christopher Simmonds (@benibenj) latest |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
{ icon: false, label: true }with text-link CSS.Codicon.openPreviewas an icon-only row action (label kept for tooltip/aria) and style it like other toolbar icons.createTurnChangesPreviewActionsfor unit coverage. Previewable files (markdown and HTML) get the icon; other rows stay actionless.Fixes #328520
Test plan
chatTurnPills.test.ts— icon class, empty for non-previewable files, run opens via associations, HTML preview classification from main.mdfile → open-preview icon (not blue “Preview” text).ts) have no row actionBefore / after screenshots are in #328582 (comment)