Modern UI: Update surface border color to use opaque defaults and add corresponding tests - #331177
Merged
Lee Murray (mrleemurray) merged 1 commit intoAug 17, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates Modern UI surface borders to resolve as opaque colors for improved visibility.
Changes:
- Composites default surface borders against the surface background.
- Tests dark/light surface and inherited editor border opacity.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
src/vs/workbench/common/theme.ts |
Makes default surface borders opaque. |
src/vs/workbench/contrib/styleOverrides/test/browser/styleOverrides.contribution.test.ts |
Verifies opaque surface/editor borders across themes. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Benjamin Christopher Simmonds (benibenj)
approved these changes
Aug 17, 2026
Lee Murray (mrleemurray)
deleted the
mrleemurray/economic-purple-albatross
branch
August 17, 2026 12:40
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enhance the surface border color to use opaque defaults for better visibility. Add tests to ensure the new behavior is correctly implemented across different themes.