Update chat in editor titles after rename tool

[Dmitriy Vasyura (dmitrivMS)]

Summary

• synchronize a renamed default chat with its owning session in the Agent Host, so the existing session-summary pipeline updates every editor-window session list
• apply the same host-owned behavior for the rename_chat tool, client/UI editor renames, and /rename, while keeping peer-chat titles independent
• route editor rename callbacks through the addressed chat channel rather than the parent session
• resolve editor-tab titles from the canonical addressed chat; an empty canonical default-chat title inherits the session title, while routing-default peers do not
• snapshot and persist an inherited canonical default-chat title when the first peer appears, without overwriting an existing or newer title, so later session renames and restarts preserve independence
• remove the editor-window session-list action overlay; merged PR agents window: fix sessions list progress #331394 publishes the resulting session-title change through root/sessionSummaryChanged
• update the rename_chat model description to match the default-chat/session and independent-peer behavior

Testing

• npm run eslint -- on the changed Agent Host and workbench files
• npm run typecheck-client
• 108 targeted tests covering Agent Host rename persistence/failure, editor and /rename routing, restored multi-chat catalogs, snapshot races, tool definitions, editor titles, and editor-window session-list behavior

Fixes #331487

[Copilot]

Pull request overview

Updates Agent Host chat editor and session-list titles after live rename actions.

Changes:

• Selects per-chat titles for multi-chat sessions.
• Preserves session titles for sole default chats.
• Adds live title synchronization and targeted tests.

Show a summary per file

File	Description
agentHostSessionHandler.ts	Resolves and synchronizes editor titles.
agentHostSessionListStore.ts	Applies live title actions to session-list entries.
agentHostChatContribution.test.ts	Tests session-list and editor title updates.

Review details

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

• Files reviewed: 3/3 changed files
• Comments generated: 1
• Review effort level: Balanced

[Copilot]

Review details

Suppressed comments (1)

Previously missed (1) — in code that hasn't changed since the last review.

src/vs/workbench/contrib/chat/browser/agentSessions/agentHost/agentHostSessionListStore.ts:352

• This title is only retained in the current _entries value. A default-chat rename in a multi-chat session updates the chat catalog but not the session title (agentService.ts:1175-1200), while a later listSessions() refresh rebuilds metadata from liveSummary.title (agentService.ts:1276-1284). Consequently, an action received before the entry is cached—or any later cache invalidation such as a workspace change—restores the old session title. Please retain the effective default-chat title independently and reapply it during refresh, or expose that effective title from listSessions().

		const cached = this._entries.get(key);
		if (!cached || cached.summary.title === title) {

• Files reviewed: 3/3 changed files
• Comments generated: 0 new
• Review effort level: Balanced

[Connor Peet (connor4312)]

comments

[Dmitriy Vasyura (dmitrivMS)]

Will wait for the #331394 to merge first

[Dmitriy Vasyura (dmitrivMS)]

comments

Thank you!

[Dmitriy Vasyura (dmitrivMS)]

I mentioned in my review above

I think we should have logic in the agent host to update the session title when the default chat title gets named, then we wouldn't have additional special-casing logic UI side

I don't think we should need the _onAction block at all

Done

[Dmitriy Vasyura (dmitrivMS)]

Reworked the PR after #331394 merged and the issue still reproduced. Commit 37008ea moves the list-visible fix into Agent Host, removes the editor list action overlay, aligns tool/UI//rename default-chat behavior, and adds persistence/restoration coverage. Local validation: ESLint, client type-check, and 83 targeted tests passed.

[Copilot]

Review details

Suppressed comments (1)

src/vs/workbench/contrib/chat/browser/agentSessions/agentHost/agentHostSessionHandler.ts:1467

• Renaming an open chat still dispatches SessionTitleChanged to the owning session URI below. Once a peer has caused the default chat title to be snapshotted, this changes only the session title, so the addressed editor tab keeps its old catalog title; renaming a peer editor also renames the owning session instead of that peer. Dispatch through the mapped chat channel when one is available so the new host-side chat/default routing is exercised.

				chatTitle,

• Files reviewed: 9/9 changed files
• Comments generated: 1
• Review effort level: Balanced

[Copilot]

Review details

• Files reviewed: 11/11 changed files
• Comments generated: 1
• Review effort level: Balanced

[Copilot]

Review details

• Files reviewed: 15/15 changed files
• Comments generated: 1
• Review effort level: Balanced

[Copilot]

Review details

• Files reviewed: 15/15 changed files
• Comments generated: 1
• Review effort level: Balanced