Update tab actions visibility for active tabs in Modern UI - #331629
Draft
Lee Murray (mrleemurray) wants to merge 1 commit into
Draft
Update tab actions visibility for active tabs in Modern UI#331629Lee Murray (mrleemurray) wants to merge 1 commit into
Lee Murray (mrleemurray) wants to merge 1 commit into
Conversation
Lee Murray (mrleemurray)
enabled auto-merge (squash)
August 19, 2026 11:24
Lee Murray (mrleemurray)
added
the
candidate
Lee Murray (mrleemurray)
removed
the
candidate
Contributor
There was a problem hiding this comment.
Pull request overview
Restricts always-visible reserved tab actions to active Modern UI tabs.
Changes:
- Scopes reserved action visibility and pointer interaction to active tabs.
- Expands CSS-state tests across active and inactive editor groups.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
modernUI.contribution.test.ts |
Tests reserved action visibility and interaction states. |
tabs.css |
Limits persistent reserved actions to active tabs. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Contributor
Screenshot ChangesBase: Changed (100)
|
| Before | After |
|---|---|
 |
 |
sessions/editorHeader/editorHeader/FullHeader/Light
| Before | After |
|---|---|
 |
 |
sessions/editorHeader/editorHeader/BreadcrumbsAndAction/Dark
| Before | After |
|---|---|
 |
 |
sessions/editorHeader/editorHeader/BreadcrumbsAndAction/Light
| Before | After |
|---|---|
 |
 |
sessions/editorHeader/editorHeader/BreadcrumbsAndSecondaryAction/Dark
| Before | After |
|---|---|
 |
 |
sessions/editorHeader/editorHeader/BreadcrumbsAndSecondaryAction/Light
| Before | After |
|---|---|
 |
 |
sessions/editorHeader/editorHeader/BreadcrumbsOnly/Dark
| Before | After |
|---|---|
 |
 |
sessions/editorHeader/editorHeader/BreadcrumbsOnly/Light
| Before | After |
|---|---|
 |
 |
sessions/editorHeader/editorHeader/PrimaryActionOnly/Dark
| Before | After |
|---|---|
 |
 |
sessions/editorHeader/editorHeader/PrimaryActionOnly/Light
| Before | After |
|---|---|
 |
 |
sessions/editorHeader/editorHeader/SecondaryActionOnly/Dark
| Before | After |
|---|---|
 |
 |
sessions/editorHeader/editorHeader/SecondaryActionOnly/Light
| Before | After |
|---|---|
 |
 |
sessions/editorHeader/editorHeader/LayoutActionsOnly/Dark
| Before | After |
|---|---|
 |
 |
sessions/editorHeader/editorHeader/LayoutActionsOnly/Light
| Before | After |
|---|---|
 |
 |
editor/editorTabBar/editorTabBar/ModernUIOn/Default/Dark
| Before | After |
|---|---|
 |
 |
editor/editorTabBar/editorTabBar/ModernUIOn/Default/Light
| Before | After |
|---|---|
 |
 |
editor/editorTabBar/editorTabBar/ModernUIOn/PinnedTabsOnSeparateRowAllUnpinned/Dark
| Before | After |
|---|---|
 |
 |
editor/editorTabBar/editorTabBar/ModernUIOn/PinnedTabsOnSeparateRowAllUnpinned/Light
| Before | After |
|---|---|
 |
 |
editor/editorTabBar/editorTabBar/ModernUIOn/PinnedTabsOnSeparateRowMixed/Dark
| Before | After |
|---|---|
 |
 |
editor/editorTabBar/editorTabBar/ModernUIOn/PinnedTabsOnSeparateRowMixed/Light
| Before | After |
|---|---|
 |
 |
editor/editorTabBar/editorTabBar/ModernUIOn/BreadcrumbsFilePathLast/Dark
| Before | After |
|---|---|
 |
 |
editor/editorTabBar/editorTabBar/ModernUIOn/BreadcrumbsFilePathLast/Light
| Before | After |
|---|---|
 |
 |
editor/editorTabBar/editorTabBar/ModernUIOn/BreadcrumbsIconsOff/Dark
| Before | After |
|---|---|
 |
 |
editor/editorTabBar/editorTabBar/ModernUIOn/BreadcrumbsIconsOff/Light
| Before | After |
|---|---|
 |
 |
editor/editorTabBar/editorTabBar/ModernUIOn/TabSizingShrink/Dark
| Before | After |
|---|---|
 |
 |
editor/editorTabBar/editorTabBar/ModernUIOn/TabSizingShrink/Light
| Before | After |
|---|---|
 |
 |
editor/editorTabBar/editorTabBar/ModernUIOn/TabSizingFixed/Dark
| Before | After |
|---|---|
 |
 |
editor/editorTabBar/editorTabBar/ModernUIOn/TabSizingFixed/Light
| Before | After |
|---|---|
 |
 |
editor/editorTabBar/editorTabBar/ModernUIOn/TabHeightCompact/Dark
| Before | After |
|---|---|
 |
 |
editor/editorTabBar/editorTabBar/ModernUIOn/TabHeightCompact/Light
| Before | After |
|---|---|
 |
 |
editor/editorTabBar/editorTabBar/ModernUIOn/WrapTabs/Dark
| Before | After |
|---|---|
 |
 |
editor/editorTabBar/editorTabBar/ModernUIOn/WrapTabs/Light
| Before | After |
|---|---|
 |
 |
editor/editorTabBar/editorTabBar/ModernUIOn/TabActionLocationLeft/Dark
| Before | After |
|---|---|
 |
 |
editor/editorTabBar/editorTabBar/ModernUIOn/TabActionLocationLeft/Light
| Before | After |
|---|---|
 |
 |
editor/editorTabBar/editorTabBar/ModernUIOn/TabActionUnpinHidden/Dark
| Before | After |
|---|---|
 |
 |
editor/editorTabBar/editorTabBar/ModernUIOn/TabActionUnpinHidden/Light
| Before | After |
|---|---|
 |
 |
editor/editorTabBar/editorTabBar/ModernUIOn/TabActionReserveSpaceOn/Dark
| Before | After |
|---|---|
 |
 |
editor/editorTabBar/editorTabBar/ModernUIOn/TabActionReserveSpaceOn/Light
| Before | After |
|---|---|
 |
 |
editor/editorTabBar/editorTabBar/ModernUIOn/ShowTabIndex/Dark
| Before | After |
|---|---|
 |
 |
editor/editorTabBar/editorTabBar/ModernUIOn/ShowTabIndex/Light
| Before | After |
|---|---|
 |
 |
editor/editorTabBar/editorTabBar/ModernUIOn/HighlightModifiedTabs/Dark
| Before | After |
|---|---|
 |
 |
editor/editorTabBar/editorTabBar/ModernUIOn/HighlightModifiedTabs/Light
| Before | After |
|---|---|
 |
 |
editor/editorTabBar/editorTabBar/ModernUIOn/LabelFormatShort/Dark
| Before | After |
|---|---|
 |
 |
editor/editorTabBar/editorTabBar/ModernUIOn/LabelFormatShort/Light
| Before | After |
|---|---|
 |
 |
editor/editorTabBar/editorTabBar/ModernUIOn/LabelFormatMedium/Dark
| Before | After |
|---|---|
 |
 |
editor/editorTabBar/editorTabBar/ModernUIOn/LabelFormatMedium/Light
| Before | After |
|---|---|
 |
 |
editor/editorTabBar/editorTabBar/ModernUIOn/LabelFormatLong/Dark
| Before | After |
|---|---|
 |
 |
editor/editorTabBar/editorTabBar/ModernUIOn/LabelFormatLong/Light
| Before | After |
|---|---|
 |
 |
editor/editorTabBar/editorTabBar/ModernUIOn/ShowIconsOff/Dark
| Before | After |
|---|---|
 |
 |
editor/editorTabBar/editorTabBar/ModernUIOn/ShowIconsOff/Light
| Before | After |
|---|---|
 |
 |
editor/editorTabBar/editorTabBar/ModernUIOn/DecorationsOff/Dark
| Before | After |
|---|---|
 |
 |
editor/editorTabBar/editorTabBar/ModernUIOn/DecorationsOff/Light
| Before | After |
|---|---|
 |
 |
editor/editorTabBar/editorTabBar/ModernUIOn/PinnedTabSizingCompact/Dark
| Before | After |
|---|---|
 |
 |
editor/editorTabBar/editorTabBar/ModernUIOn/PinnedTabSizingCompact/Light
| Before | After |
|---|---|
 |
 |
editor/editorTabBar/editorTabBar/ModernUIOn/PinnedTabSizingShrink/Dark
| Before | After |
|---|---|
 |
 |
editor/editorTabBar/editorTabBar/ModernUIOn/PinnedTabSizingShrink/Light
| Before | After |
|---|---|
 |
 |
editor/editorTabBar/editorTabBar/ModernUIOn/TitleScrollbarLarge/Dark
| Before | After |
|---|---|
 |
 |
editor/editorTabBar/editorTabBar/ModernUIOn/TitleScrollbarLarge/Light
| Before | After |
|---|---|
 |
 |
editor/editorTabBar/editorTabBar/ModernUIOn/TitleScrollbarVisible/Dark
| Before | After |
|---|---|
 |
 |
editor/editorTabBar/editorTabBar/ModernUIOn/TitleScrollbarVisible/Light
| Before | After |
|---|---|
 |
 |
editor/editorTabBar/editorTabBar/ModernUIOn/EditorActionsDefault/Dark
| Before | After |
|---|---|
|
|
editor/editorTabBar/editorTabBar/ModernUIOn/EditorActionsDefault/Light
| Before | After |
|---|---|
|
|
editor/editorTabBar/editorTabBar/ModernUIOn/EditorActionsTitleBar/Dark
| Before | After |
|---|---|
 |
 |
editor/editorTabBar/editorTabBar/ModernUIOn/EditorActionsTitleBar/Light
| Before | After |
|---|---|
 |
 |
editor/editorTabBar/editorTabBar/ModernUIOn/EditorActionsHidden/Dark
| Before | After |
|---|---|
|
|
editor/editorTabBar/editorTabBar/ModernUIOn/EditorActionsHidden/Light
| Before | After |
|---|---|
|
|
editor/editorTabBar/editorTabBar/ModernUIOn/AlwaysShowEditorActionsActiveGroup/Dark
| Before | After |
|---|---|
|
|
editor/editorTabBar/editorTabBar/ModernUIOn/AlwaysShowEditorActionsActiveGroup/Light
| Before | After |
|---|---|
|
|
editor/editorTabBar/editorTabBar/ModernUIOn/AlwaysShowEditorActionsInactiveGroup/Dark
| Before | After |
|---|---|
 |
 |
editor/editorTabBar/editorTabBar/ModernUIOn/AlwaysShowEditorActionsInactiveGroup/Light
| Before | After |
|---|---|
 |
 |
editor/editorTabBar/editorTabBar/ModernUIOn/ActiveGroup/Dark
| Before | After |
|---|---|
|
|
editor/editorTabBar/editorTabBar/ModernUIOn/ActiveGroup/Light
| Before | After |
|---|---|
|
|
editor/editorTabBar/editorTabBar/ModernUIOn/InactiveGroup/Dark
| Before | After |
|---|---|
 |
 |
editor/editorTabBar/editorTabBar/ModernUIOn/InactiveGroup/Light
| Before | After |
|---|---|
 |
 |
editor/editorTabBar/editorTabBar/ModernUIOn/MultiSelect/Dark
| Before | After |
|---|---|
 |
 |
editor/editorTabBar/editorTabBar/ModernUIOn/MultiSelect/Light
| Before | After |
|---|---|
 |
 |
editor/editorTabBar/editorTabBar/ModernUIOn/InactiveGroupDirty/Dark
| Before | After |
|---|---|
 |
 |
editor/editorTabBar/editorTabBar/ModernUIOn/InactiveGroupDirty/Light
| Before | After |
|---|---|
 |
 |
editor/editorTabBar/editorTabBar/ModernUIOn/LongLabelsShrink/Dark
| Before | After |
|---|---|
 |
 |
editor/editorTabBar/editorTabBar/ModernUIOn/LongLabelsShrink/Light
| Before | After |
|---|---|
 |
 |
editor/editorTabBar/editorTabBar/ModernUIOn/DropTargetBetweenTabs/Dark
| Before | After |
|---|---|
 |
 |
editor/editorTabBar/editorTabBar/ModernUIOn/DropTargetBetweenTabs/Light
| Before | After |
|---|---|
 |
 |
editor/editorTabBar/editorTabBar/ModernUIOn/StickyCompactNoIcons/Dark
| Before | After |
|---|---|
 |
 |
editor/editorTabBar/editorTabBar/ModernUIOn/StickyCompactNoIcons/Light
| Before | After |
|---|---|
 |
 |
editor/editorTabBar/editorTabBar/ModernUIOn/CannotCloseActive/Dark
| Before | After |
|---|---|
 |
 |
editor/editorTabBar/editorTabBar/ModernUIOn/CannotCloseActive/Light
| Before | After |
|---|---|
 |
 |
editor/editorTabBar/editorTabBar/ModernUIOn/CannotCloseDirty/Dark
| Before | After |
|---|---|
 |
 |
editor/editorTabBar/editorTabBar/ModernUIOn/CannotCloseDirty/Light
| Before | After |
|---|---|
 |
 |
editor/editorTabBar/editorTabBar/ModernUIOn/CannotCloseSticky/Dark
| Before | After |
|---|---|
 |
 |
editor/editorTabBar/editorTabBar/ModernUIOn/CannotCloseSticky/Light
| Before | After |
|---|---|
 |
 |
editor/editorTabBar/editorTabBar/ModernUIOn/PinnedSeparateRowCompact/Dark
| Before | After |
|---|---|
 |
 |
editor/editorTabBar/editorTabBar/ModernUIOn/PinnedSeparateRowCompact/Light
| Before | After |
|---|---|
 |
 |
editor/editorTabBar/editorTabBar/ModernUIOn/ThemeColors/TabStates/Dark
| Before | After |
|---|---|
 |
 |
editor/editorTabBar/editorTabBar/ModernUIOn/ThemeColors/TabStates/Light
| Before | After |
|---|---|
 |
 |
editor/editorTabBar/editorTabBar/ModernUIOn/ThemeColors/ActiveAction/Dark
| Before | After |
|---|---|
 |
 |
editor/editorTabBar/editorTabBar/ModernUIOn/ThemeColors/ActiveAction/Light
| Before | After |
|---|---|
 |
 |
editor/editorTabBar/editorTabBar/ModernUIOn/ThemeColors/ActiveHover/Dark
| Before | After |
|---|---|
 |
 |
editor/editorTabBar/editorTabBar/ModernUIOn/ThemeColors/ActiveHover/Light
| Before | After |
|---|---|
 |
 |
editor/editorTabBar/editorTabBar/ModernUIOn/ThemeColors/SelectedAction/Dark
| Before | After |
|---|---|
 |
 |
editor/editorTabBar/editorTabBar/ModernUIOn/ThemeColors/SelectedAction/Light
| Before | After |
|---|---|
 |
 |
Lee Murray (mrleemurray)
marked this pull request as draft
August 19, 2026 12:21
auto-merge was automatically disabled
August 19, 2026 12:21
Pull request was converted to draft
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request updates the behavior and testing of reserved tab actions in the Modern UI tabs. The main focus is to ensure that reserved tab actions are only visible and interactive for active tabs, improving clarity and reducing confusion in the UI. The test coverage has been expanded and clarified to reflect these changes.
Modern UI tab actions behavior changes:
tabs.cssso that reserved tab actions are only visible and clickable for active tabs, rather than for all tabs when the action column is reserved. This ensures that inactive tabs do not display or allow interaction with reserved actions.Test improvements:
modernUI.contribution.test.tsto cover more scenarios, including active and inactive tabs in both active and inactive editor groups. The test now verifies that reserved tab actions are only shown for active tabs and are hidden or disabled for others.