Only swap Alt-hold close action for the hovered tab in MultiEditorTabsControl - #331772
Merged
Benjamin Christopher Simmonds (benibenj) merged 2 commits intoAug 21, 2026
Merged
Conversation
Copilot started work on behalf of
Benjamin Christopher Simmonds (benibenj)
August 20, 2026 10:13
View session
Co-authored-by: benibenj <44439583+benibenj@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Update close action to only change for hovered tab
Only swap Alt-hold close action for the hovered tab in MultiEditorTabsControl
Aug 20, 2026
Benjamin Christopher Simmonds (benibenj)
approved these changes
Aug 20, 2026
Benjamin Christopher Simmonds (benibenj)
marked this pull request as ready for review
August 20, 2026 22:33
Benjamin Christopher Simmonds (benibenj)
enabled auto-merge (squash)
August 20, 2026 22:33
Dmitriy Vasyura (dmitrivMS)
approved these changes
Aug 20, 2026
Anthony Kim (anthonykim1)
approved these changes
Aug 21, 2026
Benjamin Christopher Simmonds (benibenj)
merged commit Aug 21, 2026
ec8a43f
into
main
27 checks passed
Benjamin Christopher Simmonds (benibenj)
deleted the
copilot/update-close-action-on-hover
branch
August 21, 2026 02:33
Abdon Morales (abdonmorales)
pushed a commit
to abdonmorales/vscode-utcs
that referenced
this pull request
Aug 22, 2026
…sControl (microsoft#331772) * Initial plan * Only swap Alt-hold close action for the hovered tab Co-authored-by: benibenj <44439583+benibenj@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: benibenj <44439583+benibenj@users.noreply.github.com> (cherry picked from commit ec8a43f)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Holding Alt in
MultiEditorTabsControlswapped the per-tab close action into "Close Others" for every tab in the group at once, which is visually noisy since only one tab can actually be clicked.Changes
wantsCloseOthersAction: booleanwithhoveredTabIndex: number | undefined, tracking which single tab the mouse is currently over.mouseenter/mouseleavelisteners on each tab (inregisterTabListeners) that updatehoveredTabIndexvia a newsetHoveredTab()method.redrawTabAction()now swaps Close → Close Others only whenaltKeyis held and the tab being redrawn matcheshoveredTabIndex. Unpin behavior is unaffected.forEachTab.handleClosedEditors), preventing a tab from getting stuck showing "Close Others".