Skip to content

sessions: Align resource pill icon size - #331793

Merged
Don Jayamanne (DonJayamanne) merged 1 commit into
mainfrom
don/agents/fix-plan-icon-size-issue
Aug 20, 2026
Merged

sessions: Align resource pill icon size#331793
Don Jayamanne (DonJayamanne) merged 1 commit into
mainfrom
don/agents/fix-plan-icon-size-issue

Conversation

@DonJayamanne

Copy link
Copy Markdown
Contributor

Summary

  • size themed file icons in resource pills at the compact icon tier
  • keep resource artifact pills the same height as neighboring session metadata pills
  • let the shared small button metrics remain the source of truth instead of fixing the button height

Fixes #331788

Validation

  • npm run stylelint -- src/vs/workbench/browser/media/chatPills.css
  • rendered SessionChatPills_ArtifactSingleFile in Component Explorer (dark and light)
  • verified in Chromium that the resource pill and peer changes pill both measure 22px; the previous rule measured 26px
  • full compile was stopped at request after running too long

Fixes #331788

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot AI balanced review requested due to automatic review settings August 20, 2026 13:04
@DonJayamanne
Don Jayamanne (DonJayamanne) marked this pull request as ready for review August 20, 2026 13:11

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Aligns resource artifact pills with neighboring session metadata pills, fixing #331788.

Changes:

  • Uses the compact icon tier for themed file icons.
  • Reduces the icon layout box so shared button metrics determine pill height.
Show a summary per file
File Description
src/vs/workbench/browser/media/chatPills.css Sizes resource-pill icons and their boxes at the compact tier.

Review details

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

  • Files reviewed: 1/1 changed files
  • Comments generated: 0
  • Review effort level: Balanced

@DonJayamanne
Don Jayamanne (DonJayamanne) merged commit 225afcc into main Aug 20, 2026
28 checks passed
@DonJayamanne
Don Jayamanne (DonJayamanne) deleted the don/agents/fix-plan-icon-size-issue branch August 20, 2026 13:58
@vs-code-engineering vs-code-engineering Bot added this to the 1.135.0 milestone Aug 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Plan artifact pill is taller than other session metadata pills

3 participants