Skip to content

chore: add more foundry-local-sdk patches - #331843

Merged
Raymond Zhao (rzhao271) merged 5 commits into
mainfrom
rzhao271/fix-nm
Aug 20, 2026
Merged

chore: add more foundry-local-sdk patches#331843
Raymond Zhao (rzhao271) merged 5 commits into
mainfrom
rzhao271/fix-nm

Conversation

@rzhao271

@rzhao271 Raymond Zhao (rzhao271) commented Aug 20, 2026

Copy link
Copy Markdown
Collaborator

Copilot AI balanced review requested due to automatic review settings August 20, 2026 17:33
@rzhao271 Raymond Zhao (rzhao271) added this to the 1.135.0 milestone Aug 20, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds authenticated Foundry Local SDK installation to node-module cache jobs across supported platforms.

Changes:

  • Adds Foundry Local prepare/install phases to five pipelines.
  • Invalidates existing dependency caches.

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 5 comments.

Show a summary per file
File Description
build/azure-pipelines/win32/product-build-win32-node-modules.yml Adds Windows Foundry installation.
build/azure-pipelines/web/product-build-web-node-modules.yml Adds web Foundry installation.
build/azure-pipelines/linux/product-build-linux-node-modules.yml Adds Linux Foundry installation.
build/azure-pipelines/darwin/product-build-darwin-node-modules.yml Adds macOS Foundry installation.
build/azure-pipelines/alpine/product-build-alpine-node-modules.yml Adds Alpine Foundry installation.
build/.cachesalt Invalidates dependency caches.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread build/azure-pipelines/win32/product-build-win32-node-modules.yml
Comment thread build/azure-pipelines/web/product-build-web-node-modules.yml
Comment thread build/azure-pipelines/linux/product-build-linux-node-modules.yml
Comment thread build/azure-pipelines/alpine/product-build-alpine-node-modules.yml
Comment thread build/azure-pipelines/darwin/product-build-darwin-node-modules.yml
@rzhao271
Raymond Zhao (rzhao271) marked this pull request as ready for review August 20, 2026 18:32
@vs-code-engineering

Copy link
Copy Markdown
Contributor

📬 CODENOTIFY

The following users are being notified based on files changed in this PR:

Ladislau Szomoru (@lszomoru)

Matched files:

  • build/azure-pipelines/alpine/product-build-alpine-node-modules.yml
  • build/azure-pipelines/common/foundry-local.yml
  • build/azure-pipelines/darwin/product-build-darwin-node-modules.yml
  • build/azure-pipelines/linux/product-build-linux-node-modules.yml
  • build/azure-pipelines/web/product-build-web-node-modules.yml
  • build/azure-pipelines/win32/product-build-win32-node-modules.yml

Co-authored-by: rzhao271 <7199958+rzhao271@users.noreply.github.com>
@rzhao271
Raymond Zhao (rzhao271) merged commit 342a753 into main Aug 20, 2026
27 checks passed
@rzhao271
Raymond Zhao (rzhao271) deleted the rzhao271/fix-nm branch August 20, 2026 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants