reasoning ux: fix tools jumping + split reasoning summary headers - #331844
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Splits streamed reasoning summaries into stable rows and adjusts tool-title layout to prevent visual jumping.
Changes:
- Parses multi-header reasoning summaries into separate rows.
- Preserves leading headers as finalized titles.
- Adds coverage for streaming, grouping, and collapsed rendering.
Show a summary per file
| File | Description |
|---|---|
chatThinkingContentPart.ts |
Implements summary-row parsing, rendering, and title tracking. |
chatThinkingContent.css |
Stabilizes tool-title spacing. |
chatThinkingContentPart.test.ts |
Tests summary splitting and title behavior. |
Review details
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Suppressed comments (1)
src/vs/workbench/contrib/chat/browser/widget/chatContentParts/chatThinkingContentPart.ts:1563
- The double negative says the opposite of the intended guarantee. Use “always displayed” instead.
// keep it as the finalized title so that header is never displayed nowhere.
- Files reviewed: 3/3 changed files
- Comments generated: 1
- Review effort level: Balanced
Contributor
Screenshot ChangesBase: Changed (18)
|
| Before | After |
|---|---|
 |
 |
chat/chatAgentFeedbackReviewConfirmation/SingleComment/Light
| Before | After |
|---|---|
 |
 |
chat/chatAgentFeedbackReviewConfirmation/MixedKinds/Dark
| Before | After |
|---|---|
 |
 |
chat/chatAgentFeedbackReviewConfirmation/MixedKinds/Light
| Before | After |
|---|---|
 |
 |
chat/chatAgentFeedbackReviewConfirmation/ManyComments/Dark
| Before | After |
|---|---|
 |
 |
chat/chatAgentFeedbackReviewConfirmation/ManyComments/Light
| Before | After |
|---|---|
 |
 |
chat/chatAgentFeedbackReviewConfirmation/LongComment/Dark
| Before | After |
|---|---|
 |
 |
chat/chatAgentFeedbackReviewConfirmation/LongComment/Light
| Before | After |
|---|---|
 |
 |
chat/chatAgentFeedbackReviewConfirmation/Empty/Dark
| Before | After |
|---|---|
 |
 |
chat/chatAgentFeedbackReviewConfirmation/Empty/Light
| Before | After |
|---|---|
 |
 |
chat/chatAgentFeedbackReviewConfirmation/Carousel/Dark
| Before | After |
|---|---|
 |
 |
chat/chatAgentFeedbackReviewConfirmation/Carousel/Light
| Before | After |
|---|---|
 |
 |
chat/chatToolRiskBadge/BadgeOffWithDisclaimerInContext/Dark
| Before | After |
|---|---|
 |
 |
chat/chatToolRiskBadge/BadgeOffWithDisclaimerInContext/Light
| Before | After |
|---|---|
 |
 |
chat/chatToolRiskBadge/BadgeOffUnsandboxedInContext/Dark
| Before | After |
|---|---|
 |
 |
chat/chatToolRiskBadge/BadgeOffUnsandboxedInContext/Light
| Before | After |
|---|---|
 |
 |
chat/chatToolRiskBadge/BadgeOffUnsandboxedWithDisclaimerInContext/Dark
| Before | After |
|---|---|
 |
 |
chat/chatToolRiskBadge/BadgeOffUnsandboxedWithDisclaimerInContext/Light
| Before | After |
|---|---|
 |
 |
Justin Chen (justschen)
marked this pull request as ready for review
August 20, 2026 22:28
Justin Chen (justschen)
enabled auto-merge (squash)
August 20, 2026 22:28
Ben Villalobos (benvillalobos)
approved these changes
Aug 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes issues where thinking headers looked bad. and jumped.